Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Universal Analytics from static #3360

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Remove Universal Analytics from static #3360

merged 1 commit into from
Jul 1, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Jun 19, 2024

This includes some new code in surveys.js to start the code if usage consent is given, as the previous code would only start the survey code if the UA client id existed.

Follow these steps if you are doing a Rails upgrade.

@AshGDS AshGDS force-pushed the remove-ua branch 2 times, most recently from 6cc67ec to 9e11516 Compare June 19, 2024 11:01
This includes some new code in surveys.js to start the code if usage consent is given, as the previous code would only start the survey code if the UA client id existed.
@AshGDS AshGDS changed the title [DO NOT MERGE] Remove UA from surveys.js and global-bar.js [DO NOT MERGE] Remove Universal Analytics from static Jun 19, 2024
@AshGDS AshGDS requested a review from andysellick June 19, 2024 13:34
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👏

@AshGDS
Copy link
Contributor Author

AshGDS commented Jun 24, 2024

Thanks @andysellick

@AshGDS AshGDS changed the title [DO NOT MERGE] Remove Universal Analytics from static Remove Universal Analytics from static Jul 1, 2024
@AshGDS AshGDS marked this pull request as ready for review July 1, 2024 10:34
@AshGDS AshGDS merged commit 1bbf63d into main Jul 1, 2024
11 checks passed
@AshGDS AshGDS deleted the remove-ua branch July 1, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants